[DUBBO-3137]: get rid of ConfigConstants, RpcConstatns, RemotingConstants #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4138 +/- ##
============================================
- Coverage 62.92% 62.88% -0.04%
+ Complexity 505 504 -1
============================================
Files 768 769 +1
Lines 33064 33060 -4
Branches 5220 5218 -2
============================================
- Hits 20805 20791 -14
- Misses 9859 9868 +9
- Partials 2400 2401 +1
Continue to review full report at Codecov.
|
CrazyHZM
reviewed
May 26, 2019
| @@ -209,10 +209,10 @@ public ChannelHandler getChannelHandler() { | |||
| public void reset(URL url) { | |||
| server.reset(url); | |||
| try { | |||
| int currHeartbeat = UrlUtils.getHeartbeat(getUrl()); | |||
| int currIdleTimeout = UrlUtils.getIdleTimeout(getUrl()); | |||
| int currHeartbeat = org.apache.dubbo.remoting.utils.UrlUtils.getHeartbeat(getUrl()); | |||
...pi/src/main/java/org/apache/dubbo/remoting/exchange/support/header/HeaderExchangeServer.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/apache/dubbo/remoting/exchange/support/header/HeaderExchangeServer.java
Outdated
Show resolved
Hide resolved
|
@CrazyHZM pls. take a look again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
issue #3137: get rid of ConfigConstants, RpcConstatns, RemotingConstants
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.