Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qos configuration cannot work. #4377 #4378

Merged
merged 1 commit into from Jun 25, 2019

Conversation

cvictory
Copy link
Contributor

@cvictory cvictory requested a review from chickenlj June 24, 2019 09:27
@cvictory cvictory added this to the 2.7.3 milestone Jun 24, 2019
@codecov-io
Copy link

Codecov Report

Merging #4378 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4378      +/-   ##
============================================
- Coverage     62.97%   62.89%   -0.09%     
+ Complexity      451      450       -1     
============================================
  Files           769      769              
  Lines         32995    32995              
  Branches       5215     5215              
============================================
- Hits          20779    20751      -28     
- Misses         9818     9844      +26     
- Partials       2398     2400       +2
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/ApplicationConfig.java 91.3% <ø> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 64.75% <0%> (-2.46%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 81.6% <0%> (-1.15%) 0% <0%> (ø)
...ache/dubbo/registry/multiple/MultipleRegistry.java 62.67% <0%> (-0.71%) 20% <0%> (-1%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa619c9...5376161. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 18773aa into apache:master Jun 25, 2019
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Jun 25, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants