Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified code #4865

Merged
merged 6 commits into from Aug 19, 2019
Merged

simplified code #4865

merged 6 commits into from Aug 19, 2019

Conversation

leechor
Copy link
Contributor

@leechor leechor commented Aug 18, 2019

What is the purpose of the change

simplified code, not change the behaviour

Brief changelog

  • add @OverRide on invoke in the subclass of Invoker
  • clearify Loadbalance weight calculate
  • simplfiy instantiateForDeserialize method's logic

Verifying this change

passed

@codecov-io
Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #4865 into master will decrease coverage by 0.05%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4865      +/-   ##
============================================
- Coverage     63.97%   63.92%   -0.06%     
+ Complexity      452      451       -1     
============================================
  Files           769      769              
  Lines         33177    33160      -17     
  Branches       5229     5228       -1     
============================================
- Hits          21226    21197      -29     
- Misses         9530     9546      +16     
+ Partials       2421     2417       -4
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/extension/ExtensionLoader.java 79% <ø> (ø) 0 <0> (ø) ⬇️
...o/rpc/cluster/loadbalance/AbstractLoadBalance.java 52.94% <100%> (+5.88%) 0 <0> (ø) ⬇️
...ache/dubbo/common/beanutil/JavaBeanDescriptor.java 91.66% <100%> (+2.77%) 0 <0> (ø) ⬇️
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 80.79% <90%> (+1.48%) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 65.85% <0%> (-17.08%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 64.75% <0%> (-2.46%) 0% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171ed25...e52a5df. Read the comment docs.

Copy link

@Moriadry-zz Moriadry-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pr looks good, pls check my suggestions.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@beiwei30 beiwei30 merged commit 00653c3 into apache:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants