New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplified code #4865
simplified code #4865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4865 +/- ##
============================================
- Coverage 63.97% 63.92% -0.06%
+ Complexity 452 451 -1
============================================
Files 769 769
Lines 33177 33160 -17
Branches 5229 5228 -1
============================================
- Hits 21226 21197 -29
- Misses 9530 9546 +16
+ Partials 2421 2417 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your pr looks good, pls check my suggestions.
dubbo-common/src/main/java/org/apache/dubbo/common/beanutil/JavaBeanDescriptor.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/test/java/org/apache/dubbo/common/beanutil/JavaBeanSerializeUtilTest.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/test/java/org/apache/dubbo/common/beanutil/JavaBeanSerializeUtilTest.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/test/java/org/apache/dubbo/common/beanutil/JavaBeanSerializeUtilTest.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/common/beanutil/JavaBeanDescriptor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
What is the purpose of the change
simplified code, not change the behaviour
Brief changelog
Verifying this change
passed