Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default setting #5067

Closed
wants to merge 19 commits into from
Closed

fix default setting #5067

wants to merge 19 commits into from

Conversation

brucelwl
Copy link
Contributor

1、需要通过AnnotatedMethodElement 获取里面的注解信息及引用对象,但是这个类是私有的, 将他改成public,比较合理.

2、还有 DubboConfigBindingBeanPostProcessor 将这两个属性值固定死了, 无论外部bean怎么配置都会在这里改变,所以将这两个属性改成局部变量比较合理
private boolean ignoreUnknownFields = true;
private boolean ignoreInvalidFields = true;

这是2.7.x版本,请看2.6.x 版本:#4955

@biyuhao
Copy link
Member

biyuhao commented Sep 23, 2019

hi @brucelwl would you mind resolving the conflict so we can merge it

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 10 committers have signed the CLA.

✅ brucelwl
✅ imsunv
✅ Moriadry
✅ zhaozhiwei2017
✅ chickenlj
✅ mzorro
✅ sonymoon
❌ cvictory
❌ biyuhao
❌ xiaoheng1
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #5067 into master will decrease coverage by <.01%.
The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5067      +/-   ##
============================================
- Coverage     64.16%   64.15%   -0.01%     
  Complexity      462      462              
============================================
  Files           769      769              
  Lines         33250    33250              
  Branches       5238     5238              
============================================
- Hits          21335    21332       -3     
+ Misses         9493     9492       -1     
- Partials       2422     2426       +4
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...nnotation/DubboConfigBindingBeanPostProcessor.java 81.03% <100%> (+6.79%) 0 <0> (ø) ⬇️
...nnotation/AnnotationInjectedBeanPostProcessor.java 63.69% <33.33%> (-2.98%) 0 <0> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 70.73% <0%> (-9.76%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0%> (-4.55%) 20% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...ava/org/apache/dubbo/common/utils/ConfigUtils.java 80% <0%> (-0.75%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.41% <0%> (-0.35%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (+4.34%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 17% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576ee2c...acc43a0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet