Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Using the ID of Dubbo Config as the alias of Bean #5094

Merged
merged 9 commits into from
Sep 23, 2019

Conversation

mercyblitz
Copy link
Contributor

The correlative issue: #5093

@mercyblitz mercyblitz added this to the 2.7.4 milestone Sep 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #5094 into 2.7.4-release will increase coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             2.7.4-release   #5094      +/-   ##
==================================================
+ Coverage            63.96%     64%   +0.03%     
+ Complexity             451     450       -1     
==================================================
  Files                  769     770       +1     
  Lines                33261   33270       +9     
  Branches              5249    5250       +1     
==================================================
+ Hits                 21275   21293      +18     
+ Misses                9554    9544      -10     
- Partials              2432    2433       +1
Impacted Files Coverage Δ Complexity Δ
...nnotation/DubboConfigBindingBeanPostProcessor.java 73.21% <ø> (-1.03%) 0 <0> (ø)
...apache/dubbo/config/spring/util/BeanRegistrar.java 71.42% <0%> (-11.91%) 0 <0> (ø)
.../annotation/DubboConfigConfigurationRegistrar.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...onfig/spring/schema/DubboBeanDefinitionParser.java 66.05% <100%> (+0.47%) 0 <0> (ø) ⬇️
...tory/annotation/DubboConfigAliasPostProcessor.java 91.66% <91.66%> (ø) 0 <0> (?)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-3.41%) 19% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (-0.63%) 29% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90f571...3c90cb2. Read the comment docs.

@mercyblitz mercyblitz merged commit 7f5e9df into apache:2.7.4-release Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants