New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #6306. support TypeBuilder sort #6365
Conversation
@@ -28,6 +28,11 @@ | |||
@SPI | |||
public interface TypeBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend to implement the interface org.apache.dubbo.common.lang.Prioritized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经修改。
@@ -36,14 +37,20 @@ | |||
*/ | |||
public class TypeDefinitionBuilder { | |||
private static final Logger logger = LoggerFactory.getLogger(TypeDefinitionBuilder.class); | |||
private static final List<TypeBuilder> BUILDERS; | |||
static final List<TypeBuilder> BUILDERS; | |||
|
|||
static { | |||
List<TypeBuilder> builders = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then invoke org.apache.dubbo.common.extension.ExtensionLoader#getSupportedExtensionInstances() using the internal sorting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
as the title.