Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#6908] Extract AccessibleObject.setAccessible(boolean) to ReflectUtils #6909

Merged
merged 7 commits into from
Mar 11, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#6908

@horizonzy
Copy link
Member Author

@htynkn Hi, I notice project call AccessibleObject.setAccessible(boolean) somewhere, it should be extract unifiedly in ReflectUtils。

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #6909 (ec3cf6c) into master (2062cdb) will decrease coverage by 0.03%.
The diff coverage is 75.60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6909      +/-   ##
============================================
- Coverage     59.05%   59.02%   -0.04%     
  Complexity      463      463              
============================================
  Files          1044     1043       -1     
  Lines         42485    42475      -10     
  Branches       6230     6219      -11     
============================================
- Hits          25091    25069      -22     
- Misses        14592    14609      +17     
+ Partials       2802     2797       -5     
Impacted Files Coverage Δ Complexity Δ
...enter/support/nacos/NacosDynamicConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/org/apache/dubbo/rpc/AppResponse.java 55.69% <ø> (ø) 0.00 <0.00> (ø)
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java 21.27% <0.00%> (+0.65%) 0.00 <0.00> (ø)
...va/org/apache/dubbo/common/utils/ReflectUtils.java 70.55% <76.47%> (+0.13%) 0.00 <0.00> (ø)
...o/rpc/cluster/support/MergeableClusterInvoker.java 40.90% <100.00%> (+1.58%) 0.00 <0.00> (ø)
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 80.79% <100.00%> (ø) 0.00 <0.00> (ø)
...java/org/apache/dubbo/common/utils/FieldUtils.java 90.32% <100.00%> (+4.60%) 0.00 <0.00> (ø)
...ava/org/apache/dubbo/common/utils/MethodUtils.java 64.89% <100.00%> (-0.06%) 0.00 <0.00> (ø)
.../java/org/apache/dubbo/common/utils/PojoUtils.java 73.29% <100.00%> (+0.12%) 0.00 <0.00> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2062cdb...ec3cf6c. Read the comment docs.

@AlbumenJ
Copy link
Member

AlbumenJ commented Dec 4, 2020

lgtm

@horizonzy
Copy link
Member Author

lgtm

Thanks for your review.
Can you help to review #6905, I hope it be merged before this one.

@AlbumenJ AlbumenJ merged commit d225d64 into apache:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants