Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-6963] fix bug: delete last config not take effect #6964

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

wikiwikiwiki
Copy link

fix #6963 ,修复删除最后一条动态配置不会生效的问题

@AlbumenJ
Copy link
Member

@wikiwikiwiki Hi, thanks for your contribution.

Please merge the latest master branch to resolve confilcts.

@AlbumenJ AlbumenJ added the status/waiting-for-feedback Need reporters to triage label Apr 12, 2021
# Conflicts:
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
@wikiwikiwiki
Copy link
Author

@wikiwikiwiki Hi, thanks for your contribution.

Please merge the latest master branch to resolve confilcts.

already resolved

@codecov-commenter
Copy link

Codecov Report

Merging #6964 (f420df1) into master (68062c1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6964      +/-   ##
============================================
- Coverage     59.17%   59.13%   -0.04%     
  Complexity      529      529              
============================================
  Files          1076     1076              
  Lines         43451    43451              
  Branches       6352     6352              
============================================
- Hits          25711    25696      -15     
- Misses        14901    14919      +18     
+ Partials       2839     2836       -3     
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/registry/integration/RegistryProtocol.java 57.94% <0.00%> (ø) 0.00 <0.00> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 59.40% <0.00%> (-4.96%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.14% <0.00%> (-1.49%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68062c1...f420df1. Read the comment docs.

@AlbumenJ
Copy link
Member

LGTM.

@wikiwikiwiki Do you have any time to add some unit test cases for this? I will merge this pr later, and we can do it in a new pull request.

@AlbumenJ AlbumenJ merged commit 5af0128 into apache:master Apr 30, 2021
@wikiwikiwiki
Copy link
Author

LGTM.

@wikiwikiwiki Do you have any time to add some unit test cases for this? I will merge this pr later, and we can do it in a new pull request.

ok

goodjava pushed a commit to WZD-MI/incubator-dubbo that referenced this pull request May 6, 2021
* fix bug: delete last config not take effect

* merge master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

最后一条动态配置删除不生效
4 participants