Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7089] NacosRegistry register instance support PreservedMetadataKeys #7090

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7089

@horizonzy
Copy link
Member Author

@AlbumenJ PTAL

@codecov-io
Copy link

codecov-io commented Mar 1, 2021

Codecov Report

Merging #7090 (079c18e) into master (4ad2634) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7090      +/-   ##
============================================
- Coverage     59.06%   58.83%   -0.23%     
+ Complexity      462      461       -1     
============================================
  Files          1043     1044       +1     
  Lines         42445    42473      +28     
  Branches       6222     6227       +5     
============================================
- Hits          25071    24991      -80     
- Misses        14574    14660      +86     
- Partials       2800     2822      +22     
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-27.59%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/exchange/Request.java 74.50% <0.00%> (-13.73%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0.00%> (-13.64%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0.00%> (-10.17%) 0.00% <0.00%> (ø%)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad2634...977f145. Read the comment docs.

Copy link

@KeRan213539 KeRan213539 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If the PR is merged, please update the corresponding document in https://github.com/apache/dubbo-website

@horizonzy
Copy link
Member Author

LGTM.
If the PR is merged, please update the corresponding document in https://github.com/apache/dubbo-website

That's fine, also append a pr to use it in dubbo-sample.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 34b744b into apache:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants