Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7259] Separate metadataReport cache file base by application dimension. #7260

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7259

@codecov-io
Copy link

codecov-io commented Feb 24, 2021

Codecov Report

Merging #7260 (1a44996) into master (1c10627) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7260      +/-   ##
============================================
- Coverage     59.56%   59.55%   -0.02%     
  Complexity      476      476              
============================================
  Files          1042     1042              
  Lines         42350    42357       +7     
  Branches       6206     6207       +1     
============================================
- Hits          25225    25224       -1     
- Misses        14301    14306       +5     
- Partials       2824     2827       +3     
Impacted Files Coverage Δ Complexity Δ
.../dubbo/metadata/report/MetadataReportInstance.java 10.34% <0.00%> (-0.37%) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 70.21% <0.00%> (-4.26%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0.00%> (-3.28%) 0.00% <0.00%> (ø%)
...he/dubbo/rpc/protocol/hessian/HessianProtocol.java 67.46% <0.00%> (-2.41%) 9.00% <0.00%> (ø%)
...ache/dubbo/cache/support/expiring/ExpiringMap.java 44.91% <0.00%> (-1.58%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (-1.49%) 0.00% <0.00%> (ø%)
.../main/java/org/apache/dubbo/common/Parameters.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c10627...1a44996. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 5472b38 into apache:master Feb 25, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants