Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7261] Remove unnecessary logger which is defined at subclass. #7262

Merged
merged 4 commits into from
Mar 15, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7261.

@codecov-io
Copy link

codecov-io commented Feb 24, 2021

Codecov Report

Merging #7262 (3c30c78) into master (d009d0c) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7262      +/-   ##
============================================
- Coverage     58.72%   58.67%   -0.06%     
+ Complexity      425      423       -2     
============================================
  Files          1043     1043              
  Lines         42471    42458      -13     
  Branches       6212     6212              
============================================
- Hits          24942    24912      -30     
- Misses        14748    14763      +15     
- Partials       2781     2783       +2     
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/config/ConfigCenterConfig.java 76.92% <ø> (ø) 0.00 <0.00> (ø)
...bo/metadata/store/consul/ConsulMetadataReport.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../dubbo/metadata/store/etcd/EtcdMetadataReport.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ubbo/metadata/store/nacos/NacosMetadataReport.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ubbo/metadata/store/redis/RedisMetadataReport.java 23.37% <ø> (-0.99%) 5.00 <0.00> (-1.00)
...adata/store/zookeeper/ZookeeperMetadataReport.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...org/apache/dubbo/registry/dubbo/DubboRegistry.java 56.00% <ø> (-0.87%) 9.00 <0.00> (-1.00)
...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.90% <ø> (+0.77%) 0.00 <0.00> (ø)
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d009d0c...3c30c78. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants