Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7297] When first call getServiceAppMapping, reduce once network transport. #7298

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7297.

@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #7298 (83e6a2f) into master (eef6b45) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7298      +/-   ##
============================================
- Coverage     59.06%   59.03%   -0.04%     
+ Complexity      462      461       -1     
============================================
  Files          1044     1044              
  Lines         42480    42480              
  Branches       6229     6229              
============================================
- Hits          25090    25077      -13     
- Misses        14591    14599       +8     
- Partials       2799     2804       +5     
Impacted Files Coverage Δ Complexity Δ
...adata/store/zookeeper/ZookeeperMetadataReport.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 70.21% <0.00%> (-4.26%) 0.00% <0.00%> (ø%)
...he/dubbo/rpc/protocol/hessian/HessianProtocol.java 67.46% <0.00%> (-2.41%) 9.00% <0.00%> (ø%)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.81% <0.00%> (-1.19%) 27.00% <0.00%> (-1.00%)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.12% <0.00%> (-0.93%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) 31.00% <0.00%> (ø%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.38% <0.00%> (-0.35%) 0.00% <0.00%> (ø%)
...apache/dubbo/common/extension/ExtensionLoader.java 78.07% <0.00%> (-0.23%) 0.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef6b45...83e6a2f. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit a299844 into apache:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants