Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test dependencies and Maven plugins #7330

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

martin-g
Copy link
Member

@martin-g martin-g commented Mar 5, 2021

What is the purpose of the change

I am trying to build Dubbo on ARM64 hardware and there are some test failures due to a usage of old versions of some test dependencies:

/tmp/1614937941285-0/redis-server-2.8.19: 1: ELF: not found                                                                                                                                                    
/tmp/1614937941285-0/redis-server-2.8.19: 2: Syntax error: word unexpected (expecting ")")             
/tmp/1614937941372-0/redis-server-2.8.19: 1: ELF: not found                                                                                                                                                    
/tmp/1614937941372-0/redis-server-2.8.19: 2: Syntax error: word unexpected (expecting ")")                                                                                                                     
/tmp/1614937941446-0/redis-server-2.8.19: 1: ELF: not found                                                                                                                                                    
/tmp/1614937941446-0/redis-server-2.8.19: 2: Syntax error: word unexpected (expecting ")")                                                                                                                     
/tmp/1614937941484-0/redis-server-2.8.19: 1: ELF: not found                                                                                                                                                    
/tmp/1614937941484-0/redis-server-2.8.19: 2: Syntax error: word unexpected (expecting ")")                                                                                                                     
/tmp/1614937941520-0/redis-server-2.8.19: 1: ELF: not found                                                                                                                                                    
/tmp/1614937941520-0/redis-server-2.8.19: 2: Syntax error: word unexpected (expecting ")")                                                                                                                     
/tmp/1614937941556-0/redis-server-2.8.19: 1: ELF: not found                                                                                                                                                    
/tmp/1614937941556-0/redis-server-2.8.19: 2: Syntax error: word unexpected (expecting ")")                                                                                                                     
[ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 0.735 s <<< FAILURE! - in 
org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest                                               
[ERROR] testSyncStoreProvider  
Time elapsed: 0.497 s  <<< ERROR!                                                                                                                                               
java.lang.RuntimeException: Can't start redis server. Check logs for details.                                                                                                                                          
at org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest.constructor(RedisMetadataReportTest.java:80)                                                                                                                                                                     

Brief changelog

This PR updates the test infrastructure dependencies (JUnit, Mockito, Hamcrest,...) and (build related) Maven plugins.

The embedded-redis issue will be addressed in a separate PR.

Verifying this change

The build and tests are still OK after the updates!

@codecov-io
Copy link

Codecov Report

Merging #7330 (0318221) into master (eef6b45) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7330      +/-   ##
============================================
- Coverage     59.05%   58.80%   -0.26%     
+ Complexity      462      461       -1     
============================================
  Files          1044     1044              
  Lines         42480    42436      -44     
  Branches       6229     6198      -31     
============================================
- Hits          25088    24953     -135     
- Misses        14592    14673      +81     
- Partials       2800     2810      +10     
Impacted Files Coverage Δ Complexity Δ
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-20.69%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/exchange/Request.java 72.54% <0.00%> (-15.69%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.33% <0.00%> (-13.70%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-11.54%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef6b45...0318221. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit e215f3e into apache:master Mar 11, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants