Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the override method "equals" will skip branches in org.apache.dubbo.common.URL#equals #7335

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

PromiseChan
Copy link

fix org.apache.dubbo.common.URL#equals.
After comparing the parameters, the method will skip the following branches

the purpose of the change

fix the override method "equals" will skip branches after comparing the parameters in org.apache.dubbo.common.URL#equals

Brief changelog

  1. delete the code "retuen true" in line 1702 , inorder to continue the following comparing
  2. add unit test

Verifying this change

successfully continue the following comparing

…, the method will skip the following branches
@codecov-io
Copy link

codecov-io commented Mar 7, 2021

Codecov Report

Merging #7335 (a9cff89) into master (2062cdb) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7335      +/-   ##
============================================
- Coverage     59.06%   58.86%   -0.21%     
+ Complexity      463      461       -2     
============================================
  Files          1044     1044              
  Lines         42485    42484       -1     
  Branches       6230     6230              
============================================
- Hits          25094    25008      -86     
- Misses        14591    14655      +64     
- Partials       2800     2821      +21     
Impacted Files Coverage Δ Complexity Δ
...mon/src/main/java/org/apache/dubbo/common/URL.java 50.05% <ø> (+1.14%) 0.00 <0.00> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-20.69%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/exchange/Request.java 74.50% <0.00%> (-13.73%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0.00%> (-10.17%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 78.63% <0.00%> (-9.41%) 0.00% <0.00%> (ø%)
...o/remoting/transport/ChannelHandlerDispatcher.java 62.00% <0.00%> (-8.00%) 0.00% <0.00%> (ø%)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2062cdb...a9cff89. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhangyz-hd
Copy link
Contributor

LGTM.

@zhangyz-hd zhangyz-hd merged commit e02be08 into apache:master Mar 9, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants