Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7129] NacosRegistry,NacosMetadataReport,NacosDynamicConfiguration compatible with innerclass symbol '$' #7346

Merged
merged 9 commits into from
Mar 25, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7129.

@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #7346 (9ad8bd9) into master (a588723) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7346      +/-   ##
============================================
- Coverage     58.64%   58.58%   -0.06%     
  Complexity      425      425              
============================================
  Files          1043     1046       +3     
  Lines         42482    42523      +41     
  Branches       6217     6217              
============================================
- Hits          24914    24913       -1     
- Misses        14780    14824      +44     
+ Partials       2788     2786       -2     
Impacted Files Coverage Δ Complexity Δ
...enter/support/nacos/NacosConfigServiceWrapper.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...enter/support/nacos/NacosDynamicConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...etadata/store/nacos/NacosConfigServiceWrapper.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ubbo/metadata/store/nacos/NacosMetadataReport.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ubbo/registry/nacos/NacosNamingServiceWrapper.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...he/dubbo/registry/nacos/NacosServiceDiscovery.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...o/registry/nacos/util/NacosNamingServiceUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a588723...9ad8bd9. Read the comment docs.

@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Mar 25, 2021
@AlbumenJ AlbumenJ merged commit 8f8181e into apache:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants