Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Add provided-by paramater for DubboReference #7451

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

  • add providedBy parameter in DubboReference
  • make services deprecated

Related #7190

@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Mar 26, 2021
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #7451 (4f5fb2a) into master (4d5158f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7451   +/-   ##
=========================================
  Coverage     59.30%   59.30%           
+ Complexity      503      502    -1     
=========================================
  Files          1076     1076           
  Lines         43172    43172           
  Branches       6288     6288           
=========================================
+ Hits          25603    25604    +1     
  Misses        14738    14738           
+ Partials       2831     2830    -1     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 69.69% <ø> (ø) 0.00 <0.00> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) 31.00% <0.00%> (ø%)
...he/dubbo/registry/multicast/MulticastRegistry.java 69.30% <0.00%> (+0.93%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 81.11% <0.00%> (+1.11%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 82.05% <0.00%> (+1.70%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) 16.00% <0.00%> (ø%)
...g/apache/dubbo/config/AbstractReferenceConfig.java 90.00% <0.00%> (+4.00%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 96.55% <0.00%> (+6.89%) 0.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5158f...4f5fb2a. Read the comment docs.

@AlbumenJ AlbumenJ merged commit a4db596 into apache:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants