Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-7459]Fix passing wrong parameter when calling MigrationInvoker.compareAddresses() #7460

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

kevinw66
Copy link
Contributor

What is the purpose of the change

For-#7459

@codecov-io
Copy link

Codecov Report

Merging #7460 (9a8d4e2) into master (eeac3a0) will decrease coverage by 0.41%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7460      +/-   ##
============================================
- Coverage     59.38%   58.97%   -0.42%     
+ Complexity      502      501       -1     
============================================
  Files          1079     1079              
  Lines         43329    43285      -44     
  Branches       6318     6287      -31     
============================================
- Hits          25733    25526     -207     
- Misses        14759    14930     +171     
+ Partials       2837     2829       -8     
Impacted Files Coverage Δ Complexity Δ
...o/rpc/cluster/support/migration/MigrationRule.java 58.62% <0.00%> (ø) 0.00 <0.00> (ø)
...bo/registry/client/migration/MigrationInvoker.java 32.73% <50.00%> (-1.20%) 0.00 <0.00> (ø)
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 26.86% <0.00%> (-52.24%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-34.49%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 43.47% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-11.54%) 0.00% <0.00%> (ø%)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeac3a0...9a8d4e2. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@AlbumenJ AlbumenJ merged commit 907c6c5 into apache:master Mar 30, 2021
@kevinw66 kevinw66 deleted the wrong-param-compareAddresses branch April 1, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants