Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7464] Fix unlisten key miatch problem. #7465

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7464.

@codecov-io
Copy link

codecov-io commented Mar 28, 2021

Codecov Report

Merging #7465 (ff30e50) into master (041f8bb) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7465      +/-   ##
============================================
- Coverage     59.37%   59.26%   -0.11%     
+ Complexity      501      500       -1     
============================================
  Files          1077     1079       +2     
  Lines         43306    43329      +23     
  Branches       6314     6301      -13     
============================================
- Hits          25713    25679      -34     
- Misses        14752    14804      +52     
- Partials       2841     2846       +5     
Impacted Files Coverage Δ Complexity Δ
...gistry/client/migration/MigrationRuleListener.java 73.52% <50.00%> (ø) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...ntext/event/AwaitingNonWebApplicationListener.java 48.48% <0.00%> (-24.25%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...xt/DubboLifecycleComponentApplicationListener.java 92.30% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...tadata/DynamicConfigurationServiceNameMapping.java 84.21% <0.00%> (-4.98%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 70.21% <0.00%> (-4.26%) 0.00% <0.00%> (ø%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.16% <0.00%> (-3.80%) 0.00% <0.00%> (ø%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041f8bb...ff30e50. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 11d09a6 into apache:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants