Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ClusterRules LoadbalanceRules to dubbo common #7531 #7534

Merged
merged 5 commits into from
Apr 16, 2021
Merged

add ClusterRules LoadbalanceRules to dubbo common #7531 #7534

merged 5 commits into from
Apr 16, 2021

Conversation

rockit-ba
Copy link

@rockit-ba rockit-ba commented Apr 12, 2021 •
edited

fixed: #7531
add ClusterRules 、LoadbalanceRules for cluster and loadbalance properties。

We can user like
@DubboService(loadbalance = LoadbalanceRules.RANDOM,cluster = ClusterRules.FAIL_BACK)

It was like this before
@DubboService(loadbalance = "random",cluster = "failback")

@rockit-ba rockit-ba closed this Apr 12, 2021
@rockit-ba rockit-ba reopened this Apr 12, 2021
@rockit-ba rockit-ba closed this Apr 12, 2021
@rockit-ba rockit-ba reopened this Apr 12, 2021
@AlbumenJ
Copy link
Member

Please merge the latest master branch into your branch and it can trigger github actions correctly.

@rockit-ba
Copy link
Author

Please merge the latest master branch into your branch and it can trigger github actions correctly.

OK

xiaoheng1
xiaoheng1 reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: /home/runner/work/dubbo/dubbo/dubbo-common/src/main/java/org/apache/dubbo/config/annotation/Service.java:30:15: Unused import - org.apache.dubbo.common.constants.CommonConstants.DEFAULT_LOADBALANCE. [UnusedImports]
Error: /home/runner/work/dubbo/dubbo/dubbo-common/src/main/java/org/apache/dubbo/config/annotation/DubboService.java:30:15: Unused import - org.apache.dubbo.common.constants.CommonConstants.DEFAULT_LOADBALANCE. [UnusedImports]

please handle unused imports.

@rockit-ba
Copy link
Author

Error: /home/runner/work/dubbo/dubbo/dubbo-common/src/main/java/org/apache/dubbo/config/annotation/Service.java:30:15: Unused import - org.apache.dubbo.common.constants.CommonConstants.DEFAULT_LOADBALANCE. [UnusedImports]
Error: /home/runner/work/dubbo/dubbo/dubbo-common/src/main/java/org/apache/dubbo/config/annotation/DubboService.java:30:15: Unused import - org.apache.dubbo.common.constants.CommonConstants.DEFAULT_LOADBALANCE. [UnusedImports]

please handle unused imports.

OK

xiaoheng1
xiaoheng1 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

horizonzy
horizonzy approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rockit-ba rockit-ba requested a review from AlbumenJ April 13, 2021 12:30
@AlbumenJ AlbumenJ merged commit f8dd74f into apache:master Apr 16, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
@AlbumenJ
Pick from apache#7534 f8dd74f
9e4b99b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoheng1 xiaoheng1 xiaoheng1 approved these changes

@horizonzy horizonzy horizonzy approved these changes

@AlbumenJ AlbumenJ Awaiting requested review from AlbumenJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion：Constantize some configurations
4 participants
@rockit-ba @AlbumenJ @xiaoheng1 @horizonzy