Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double-check to get elements from the cache #7583

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

BurningCN
Copy link
Member

@BurningCN BurningCN commented Apr 19, 2021

for issue #7584

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2021

Codecov Report

Merging #7583 (abe87de) into master (0ddc988) will decrease coverage by 0.10%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7583      +/-   ##
============================================
- Coverage     59.17%   59.07%   -0.11%     
- Complexity      501      529      +28     
============================================
  Files          1079     1076       -3     
  Lines         43331    43420      +89     
  Branches       6318     6340      +22     
============================================
+ Hits          25641    25649       +8     
- Misses        14851    14927      +76     
- Partials       2839     2844       +5     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 65.40% <0.00%> (-4.30%) 0.00 <0.00> (ø)
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 80.16% <84.21%> (+0.33%) 0.00 <0.00> (ø)
...java/org/apache/dubbo/common/bytecode/Wrapper.java 82.53% <100.00%> (ø) 0.00 <0.00> (ø)
.../report/support/AbstractMetadataReportFactory.java 78.94% <100.00%> (-8.56%) 0.00 <0.00> (ø)
...apache/dubbo/remoting/transport/AbstractCodec.java 79.41% <100.00%> (+4.41%) 0.00 <0.00> (ø)
...he/dubbo/rpc/protocol/rmi/RmiRemoteInvocation.java 0.00% <0.00%> (-80.00%) 0.00% <0.00%> (-2.00%)
...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java 0.00% <0.00%> (-61.67%) 0.00% <0.00%> (-10.00%)
...g/context/properties/DefaultDubboConfigBinder.java 42.85% <0.00%> (-57.15%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5692210...abe87de. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 7677eb3 into apache:master Apr 21, 2021
@BurningCN BurningCN deleted the polish_cache_double_check branch May 14, 2021 04:12
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants