Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventListener implementation in DubboBootstrap #7638

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

kevinw66
Copy link
Contributor

What is the purpose of the change

DubboBootstrap implements EventListener but there is no handle event method, maybe we should remove the implementation.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #7638 (6878861) into master (2057906) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7638      +/-   ##
============================================
- Coverage     59.16%   59.09%   -0.08%     
+ Complexity      529      528       -1     
============================================
  Files          1076     1076              
  Lines         43435    43429       -6     
  Branches       6347     6347              
============================================
- Hits          25700    25666      -34     
- Misses        14904    14927      +23     
- Partials       2831     2836       +5     
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 41.70% <ø> (-0.56%) 0.00 <0.00> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-13.80%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/event/GenericEventListener.java 88.88% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 87.17% <0.00%> (-4.28%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
.../remoting/transport/netty4/NettyClientHandler.java 83.05% <0.00%> (-3.39%) 0.00% <0.00%> (ø%)
...exchange/support/header/HeaderExchangeHandler.java 66.37% <0.00%> (-2.66%) 0.00% <0.00%> (ø%)
...ting/exchange/support/header/HeartbeatHandler.java 90.69% <0.00%> (-2.33%) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2057906...6878861. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 7072cbe into apache:master Apr 27, 2021
goodjava pushed a commit to WZD-MI/incubator-dubbo that referenced this pull request May 6, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
@kevinw66 kevinw66 deleted the bootstrap-event branch July 12, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants