Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] fix random assertion failure #8702

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 6, 2021

What is the purpose of the change

fix random assertion failure mentioned in #8689

@zrlw zrlw changed the title [master] fix random assertions [master] fix random assertion failure Sep 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #8702 (13ec3c3) into master (7d95364) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8702      +/-   ##
============================================
+ Coverage     61.03%   61.07%   +0.04%     
- Complexity      448      449       +1     
============================================
  Files          1097     1097              
  Lines         44398    44398              
  Branches       6466     6466              
============================================
+ Hits          27098    27116      +18     
+ Misses        14317    14302      -15     
+ Partials       2983     2980       -3     
Impacted Files Coverage Δ
...port/identifier/BaseServiceMetadataIdentifier.java 57.14% <0.00%> (-3.58%) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 83.09% <0.00%> (-2.82%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 63.36% <0.00%> (-1.00%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 77.40% <0.00%> (-0.75%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.10% <0.00%> (-0.22%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 68.37% <0.00%> (+0.93%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.11% <0.00%> (+1.14%) ⬆️
...pache/dubbo/remoting/transport/AbstractServer.java 62.85% <0.00%> (+1.42%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d95364...13ec3c3. Read the comment docs.

@AlbumenJ AlbumenJ merged commit abb2109 into apache:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants