Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] DefaultFuture turn off logging optimization for Channel(issue #8695) #8778

Merged
merged 1 commit into from Sep 12, 2021

Conversation

stone-98
Copy link
Contributor

@stone-98 stone-98 commented Sep 12, 2021

fix issue #8695 on master

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #8778 (e23b0cc) into master (d3773a7) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8778      +/-   ##
============================================
- Coverage     61.05%   61.04%   -0.01%     
+ Complexity      448      447       -1     
============================================
  Files          1097     1097              
  Lines         44384    44387       +3     
  Branches       6461     6462       +1     
============================================
- Hits          27099    27098       -1     
- Misses        14302    14305       +3     
- Partials       2983     2984       +1     
Impacted Files Coverage Δ
...dubbo/remoting/exchange/support/DefaultFuture.java 88.28% <50.00%> (-1.19%) ⬇️
...va/org/apache/dubbo/remoting/exchange/Request.java 77.19% <100.00%> (-11.05%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 83.09% <0.00%> (-2.82%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.89% <0.00%> (-0.22%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 80.37% <0.00%> (+1.48%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0.00%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3773a7...e23b0cc. Read the comment docs.

Copy link
Contributor

@wangchengming666 wangchengming666 left a comment

LGTM

@horizonzy horizonzy merged commit 2f93930 into apache:master Sep 12, 2021
10 checks passed
@stone-98 stone-98 deleted the master-fix-issue#8695 branch Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants