Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix #9086 NPE #9420

Merged
merged 1 commit into from Dec 16, 2021
Merged

Conversation

wangchengming666
Copy link
Contributor

@wangchengming666 wangchengming666 commented Dec 15, 2021

fix #9086 NPE

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #9420 (f4c508c) into master (9cfb1ae) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9420      +/-   ##
============================================
- Coverage     60.82%   60.04%   -0.78%     
- Complexity      445      446       +1     
============================================
  Files          1100     1100              
  Lines         44509    44511       +2     
  Branches       6475     6476       +1     
============================================
- Hits          27073    26728     -345     
- Misses        14466    14834     +368     
+ Partials       2970     2949      -21     
Impacted Files Coverage Δ
...n/java/org/apache/dubbo/metadata/MetadataInfo.java 34.94% <0.00%> (-0.38%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-66.67%) ⬇️
...gcenter/wrapper/CompositeDynamicConfiguration.java 0.00% <0.00%> (-63.34%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-60.00%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 31.42% <0.00%> (-54.29%) ⬇️
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 28.35% <0.00%> (-50.75%) ⬇️
.../dubbo/metadata/report/MetadataReportInstance.java 12.50% <0.00%> (-40.63%) ⬇️
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 0.00% <0.00%> (-32.44%) ⬇️
...gistry/client/migration/MigrationRuleListener.java 55.88% <0.00%> (-23.53%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfb1ae...f4c508c. Read the comment docs.

Map<String, String> keyMap = null;
if (CollectionUtils.isNotEmptyMap(map)) {
keyMap = map.get(method);
}
Copy link
Contributor

@chickenlj chickenlj Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can avoid NPE from happing by checking before use, however, I don't think it can resolve the root methodParams initialization issue as it has a race condition that needs to be resolved.

@chickenlj
Copy link
Contributor

@chickenlj chickenlj commented Dec 16, 2021

Merged as an enhancement for avoiding #9086 NPE from appearing but it cannot resolve the root issue.

@chickenlj chickenlj merged commit c0b7f95 into apache:master Dec 16, 2021
10 checks passed
@chickenlj chickenlj added this to the 3.0.6 milestone Dec 16, 2021
@chickenlj chickenlj removed this from the 3.0.6 milestone Dec 16, 2021
@chickenlj chickenlj added this to the 2.7.15 milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants