Skip to content

Commit

Permalink
fix(custom): add info in custom renderItem #15789
Browse files Browse the repository at this point in the history
  • Loading branch information
sobolewsk committed Mar 23, 2023
1 parent 5f49fbb commit b84493a
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/core/echarts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ class ECharts extends Eventful<ECEventDefinition> {
if (ecData && ecData.dataIndex != null) {
const dataModel = ecData.dataModel || ecModel.getSeriesByIndex(ecData.seriesIndex);
params = (
dataModel && dataModel.getDataParams(ecData.dataIndex, ecData.dataType) || {}
dataModel && dataModel.getDataParams(ecData.dataIndex, ecData.dataType, el) || {}
) as ECElementEvent;
return true;
}
Expand Down
4 changes: 3 additions & 1 deletion src/util/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ export interface DataHost {
getData(dataType?: SeriesDataType): SeriesData;
}

export interface DataModel extends Model<unknown>, DataHost, DataFormatMixin {}
export interface DataModel extends Model<unknown>, DataHost, DataFormatMixin {
getDataParams(dataIndex: number, dataType?: SeriesDataType, el?: Element): CallbackDataParams;
}
// Pick<DataHost, 'getData'>,
// Pick<DataFormatMixin, 'getDataParams' | 'formatTooltip'> {}

Expand Down
42 changes: 42 additions & 0 deletions test/ut/spec/series/custom.test.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b84493a

Please sign in to comment.