style: fix code style flaw and remove unnecessary default parameter. (#…

…17098)
apache · Nov 8, 2022 · b9a19eb · b9a19eb
1 parent 0f149dc
commit b9a19eb
Show file tree

Hide file tree

Showing 4 changed files with 106 additions and 111 deletions.
diff --git a/src/chart/bar/BaseBarSeries.ts b/src/chart/bar/BaseBarSeries.ts
@@ -86,7 +86,11 @@ class BaseBarSeriesModel<Opts extends BaseBarSeriesOption<unknown> = BaseBarSeri
         return createSeriesData(null, this, {useEncodeDefaulter: true});
     }
 
-    getMarkerPosition(value: ScaleDataValue[], dims?: typeof dimPermutations[number], startingAtTick: boolean = false) {
+    getMarkerPosition(
+        value: ScaleDataValue[],
+        dims?: typeof dimPermutations[number],
+        startingAtTick?: boolean
+    ) {
         const coordSys = this.coordinateSystem;
         if (coordSys && coordSys.clampData) {
             // PENDING if clamp ?

diff --git a/src/component/marker/MarkAreaView.ts b/src/component/marker/MarkAreaView.ts
@@ -183,7 +183,7 @@ function getSingleMarkerEndPoint(
             else {
                 pointValue[1] = (clampPointValue0[1] > clampPointValue1[1]) ? pointValue0[1] : pointValue1[1];
             }
-            // Use the getMarkerPoisition
+            // Use the getMarkerPosition
             point = seriesModel.getMarkerPosition(
                 pointValue, dims, true
             );

diff --git a/src/model/Series.ts b/src/model/Series.ts
@@ -103,7 +103,8 @@ interface SeriesModel {
     getMarkerPosition(
         value: ScaleDataValue[],
         dims?: typeof dimPermutations[number],
-        startingAtTick?:boolean): number[];
+        startingAtTick?: boolean
+    ): number[];
 
     /**
      * Get legend icon symbol according to each series type

diff --git a/test/bar-markArea.html b/test/bar-markArea.html