Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom): fix series label on custom series not working properly. close #14092 #14254

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

Nick22nd
Copy link
Contributor

@Nick22nd Nick22nd commented Feb 9, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix the color of series label on custom series not following the color of bars

Fixed issues

Details

Before: What was the problem?

The color of series label on custom series followed the last/hovered bar.

14092-before

After: How is it fixed in this PR?

I read the comment below and code on v4.9.0 branch. But I'm not sure whether the fix meets requirement of comment below:

Element.ts

 outsideFill is a color string or left empty.
If a textContent is "inside", its final fill will be picked by this priority:
textContent.style.fill > textConfig.outsideFill > #000

txCfg.outsideFill always get 'auto' as default value , the color of series label should follow the color of bars.

14092-after

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 9, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang requested a review from 100pah March 1, 2021 03:01
@pissang pissang added this to the 5.1.0 milestone Mar 1, 2021
@Ovilia Ovilia linked an issue Mar 1, 2021 that may be closed by this pull request
@Ovilia Ovilia removed this from the 5.1.0 milestone Mar 1, 2021
@100pah 100pah merged commit f3471f0 into apache:master Mar 22, 2021
@echarts-bot
Copy link

echarts-bot bot commented Mar 22, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series Label on Custom Series not working properly
4 participants