Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): position callback return type. close #15030 #15031

Merged

Conversation

congjiujiu
Copy link

@congjiujiu congjiujiu commented May 25, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix tooltip position callback return types

Fixed issues

Details

Before: What was the problem?

image

After: How is it fixed in this PR?

change the return type to Array<number | string>

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented May 25, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang
Copy link
Contributor

pissang commented May 25, 2021

@congjiujiu TypeScript check fails.

image

@congjiujiu congjiujiu force-pushed the fix/tooltip-position-callback-type branch from ea25e07 to 9c28349 Compare May 25, 2021 13:17
@congjiujiu
Copy link
Author

@pissang fixed

@pissang pissang merged commit c695011 into apache:master May 26, 2021
@echarts-bot
Copy link

echarts-bot bot commented May 26, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@congjiujiu congjiujiu deleted the fix/tooltip-position-callback-type branch May 26, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants