Fix #13195 - Update way of parsing date #15410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
5 tasks
pissang
requested changes
Jul 26, 2021
pissang
changed the title
pissang
approved these changes
Jul 28, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Note
This is a re-commit for original PR #13227 . I didn't modify the original one because due to some reason I can not find my original branch.
Brief Information
This pull request is in the type of:
What does this PR do?
The PR updated way of parsing 7th part of date string from simply treat it as milliseconds to pick first 3 digits as milliseconds to avoid unexpected result when backend API return date string with precision of microseconds.
Fixed issues
#13195
Details
Before: What was the problem?
Though 3 digits milliseconds is widely used in most situations, some date formatter will return date string 6 digit microseconds (
yyyy-MM-ddTHH:mm:ss.micros) . ECharts will treat micro seconds as milliseconds when parsing DateTime string and cause unexpected result.After: How is it fixed in this PR?
Keep conistent with default constructor of JavaScript Date - only pick first 3 digits when the length of input part between dot and zulu time marker is longer than 3 digits.
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information