support 'convertFromEC4CompatibleStyle' to convert font related attributes #15454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
https://github.com/apache/echarts/blob/master/src/util/styleCompat.ts#L92 |
pissang
approved these changes
Aug 2, 2021
|
@AmosChenYQ Thanks for the fix. I think it's just forgotten. |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
pissang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…butes
Brief Information
This pull request is in the type of:
What does this PR do?
Try to support convert font related attributes.
Fixed issues
#14727
#15105
Details
Before: What was the problem?
Can not change font size or weight.
After: How is it fixed in this PR?
Can support to change it.
Misc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information