Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): tangential rotation with startAngle #15980 #16307

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Dec 30, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix pie label rotation when startAngle is set to values like 0.

Fixed issues

Details

Before: What was the problem?

In some cases, the text rotation is up-side-down and hard to read.

image

After: How is it fixed in this PR?

All text is rotated upwards for better reading.

image

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

  • test/pie-label-rotate.html

The run button changes startAngle and data to test it works in all situations.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 30, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

src/chart/pie/labelLayout.ts Outdated Show resolved Hide resolved
src/chart/pie/labelLayout.ts Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Jan 6, 2022
@Ovilia Ovilia merged commit cae5a1c into master Jan 6, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jan 6, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-15980 branch January 6, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with piechart label using startAngle and label.rotate = 'tangential' and label.position='inside'
3 participants