Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom): fix custom elements probably can't be removed due to NPE when applying leave transition #17308

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Jul 4, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix potential null pointer exception when applying leave transition on removed elements.

Fixed issues

Details

Before: What was the problem?

The elements probably can't be removed due to the unexpected NPE when applying leave transition.

image

After: How does it behave after the fixing?

Detect if the targeted element exists before applying leave transition.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the first case in test/custom.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

This was brought in the commit 393eb30. (#16225)

@echarts-bot
Copy link

echarts-bot bot commented Jul 4, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart requested a review from pissang July 4, 2022 08:09
@Ovilia Ovilia merged commit 64a86ba into master Jul 4, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jul 4, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants