fix(legend): fix legend inverse doesn't work if series data have the same name
#17510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
caiwukun
changed the title
Ovilia
approved these changes
Sep 22, 2022
Ovilia
changed the title
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
plainheart
changed the title
inverse doesn't work if series data have the same name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
remove legend name duplicate to fix legend inverse bug
Details
Before: What was the problem?
legend selector inverse function not work when using multiple series with duplicate legend name
reproduce link
In the demo, you can see the legend reverse don't work, It's beacase there are many duplicate legend name in pie chart series data, and legend reverse function will traverse these legend names, which will cause multiple times reverse of same legend name.
After: How does it behave after the fixing?
this fixing add dupliate removal before legend data update.
After the fixing, the legend reverse function work normally!
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information