Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visualMap): fix continuous visualMap mouseover event not register except first countinous visualMap #19097

Merged
merged 3 commits into from Sep 11, 2023

Conversation

linghaoSu
Copy link
Contributor

@linghaoSu linghaoSu commented Sep 8, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix multi continous visualMap , when element hovered, the visualMap not show indicator except the first one.

Fixed issues

Details

Before After
image image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Sep 8, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19097@97e3fa9

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an existing PR #17252 targeting to fix the same bug. I would suggest you read my review there and improve the fix strategy.

@linghaoSu
Copy link
Contributor Author

There is an existing PR #17252 targeting to fix the same bug. I would suggest you read my review there and improve the fix strategy.

change fix strategy depends these review there.

@plainheart plainheart merged commit a06dd62 into apache:master Sep 11, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Sep 11, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only 1 visual map indicates value if there are multiple visual maps.
2 participants