Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(continuousView): fix multi visualMap bind hoverLink listener. #17252

Closed
wants to merge 2 commits into from

Conversation

xhuz
Copy link

@xhuz xhuz commented Jun 21, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed when multiple continue visualMaps were configured, only one HoverLink binding event succeeded

Fixed issues

Details

Before: What was the problem?

image

After: How does it behave after the fixing?

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 21, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@plainheart
Copy link
Member

Thanks for your contribution! Could you please add some test cases for this change?

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And could you please also make a visual test case?

Comment on lines +112 to +114
private _ownHoverLinkFromSeriesMouseOver = (e: ElementEvent) => this._hoverLinkFromSeriesMouseOver(e);

private _ownHideIndicator = () => this._hideIndicator();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can refer to the SliderZoomView and use the same strategy.

Note that since some codes use this.api rather than this._api, you may need to change them to this._api after overriding the init function. And the assignment to this._api in doRender function can be moved into the init function.

@plainheart
Copy link
Member

Superseded by #19097

@plainheart plainheart added the inactive Not active for some time or no response from the author. Will be closed soon. label Sep 11, 2023
@plainheart plainheart closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Not active for some time or no response from the author. Will be closed soon. PR: doc unchanged PR: first-time contributor size/S waiting-for: author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants