New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(continuousView): fix multi visualMap bind hoverLink listener. #17252
Conversation
Thanks for your contribution! |
Thanks for your contribution! Could you please add some test cases for this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And could you please also make a visual test case?
private _ownHoverLinkFromSeriesMouseOver = (e: ElementEvent) => this._hoverLinkFromSeriesMouseOver(e); | ||
|
||
private _ownHideIndicator = () => this._hideIndicator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can refer to the SliderZoomView
and use the same strategy.
Note that since some codes use this.api
rather than this._api
, you may need to change them to this._api
after overriding the init
function. And the assignment to this._api
in doRender
function can be moved into the init
function.
Superseded by #19097 |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed when multiple continue visualMaps were configured, only one HoverLink binding event succeeded
Fixed issues
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information