Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: root node related edge not removed when update data #15251

Merged
merged 1 commit into from Jul 16, 2021

Conversation

ssthouse
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

#15217

Details

Before: What was the problem?

Jun-28-2021 16-37-52

After: How is it fixed in this PR?

The original logic misses the condition when the root node is changed to its child.
In this condition, the edge between the root node and its child node should be removed;

Jun-28-2021 16-40-13

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 28, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 5.2 milestone Jun 28, 2021
@pissang
Copy link
Contributor

pissang commented Jul 16, 2021

LGTM

@pissang pissang merged commit db6a91a into apache:master Jul 16, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 16, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants