Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): normalize the infinite value when calculating the visual gradient. #15416

Merged
merged 1 commit into from Jul 27, 2021

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Resolves #15407. When visualMap is enabled, the line color is unexpected.

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Revert the change brought by #14602 in LineView.ts and normalize the infinite value

coord: axis.toGlobalCoord(axis.dataToCoord(stop.value, true)),

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/linear-gradient.html.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 27, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit e5f4a00 into master Jul 27, 2021
@pissang pissang deleted the fix/line-visual-gradient branch July 27, 2021 09:34
@echarts-bot
Copy link

echarts-bot bot commented Jul 27, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart linked an issue Aug 9, 2021 that may be closed by this pull request
@pissang pissang mentioned this pull request Sep 13, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visualMap line is the wrong color 当x轴为时间轴时,visualMap展示的颜色不对
2 participants