Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sunburst): radius in levels #15706

Merged
merged 2 commits into from
Sep 10, 2021
Merged

fix(sunburst): radius in levels #15706

merged 2 commits into from
Sep 10, 2021

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Sep 10, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Some sunburst examples uses series.levels.r and series.levels.r0 but this option is not exposed in the document. After further examination, we found the original implementation supports series.data.r but we don't find the necessary scenario for this by now. And radius typed in number | number[] may be a better option name than r and r0 to be consistent with Pie series.

So this PR fixes this problem and exposes series.levels.radius to developers.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Tested and passed all sunburst* cases.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Sep 10, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: author is committer PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Sep 10, 2021
@Ovilia Ovilia added this to the 5.2.1 milestone Sep 10, 2021
src/chart/sunburst/SunburstSeries.ts Outdated Show resolved Hide resolved
src/chart/sunburst/sunburstLayout.ts Outdated Show resolved Hide resolved
src/chart/sunburst/sunburstLayout.ts Outdated Show resolved Hide resolved
@pissang pissang merged commit 01bf5f1 into master Sep 10, 2021
@echarts-bot
Copy link

echarts-bot bot commented Sep 10, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-sunburst branch September 10, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants