Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): provide ability to extend series option #15735

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Sep 16, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Previously we can't use TypeScript declaration merging feature to extend our SeriesOption in the extensions like echarts-wordcloud because it's a union type.

This PR adds an interface RegisteredSeriesOption. It can be extended with new types of series. SeriesOption will pick all its values and get a union type.

import echarts from 'echarts';
declare module 'echarts/types/dist/echarts' {
   interface RegisteredSeriesOption {
      wordCloud: WordCloudSeriesOption
   }
 }

@echarts-bot
Copy link

echarts-bot bot commented Sep 16, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 5ff6216 into release Sep 16, 2021
@pissang pissang deleted the series-type-register branch September 16, 2021 06:29
@echarts-bot
Copy link

echarts-bot bot commented Sep 16, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants