fix(bar): barMinHeight invalid. close #16565 #16572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Ovilia
requested changes
Aug 29, 2022
There was a problem hiding this comment.
Sorry for late review. Please also add a test file test/bar-stack-minHeight.html.
The following is the test content:
<!DOCTYPE html>
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1" />
<script src="lib/simpleRequire.js"></script>
<script src="lib/config.js"></script>
<script src="lib/jquery.min.js"></script>
<script src="lib/facePrint.js"></script>
<script src="lib/testHelper.js"></script>
<!-- <script src="ut/lib/canteen.js"></script> -->
<link rel="stylesheet" href="lib/reset.css" />
</head>
<body>
<style>
</style>
<div id="main0"></div>
<div id="main1"></div>
<script>
require([
'echarts',
// 'map/js/china',
// './data/nutrients.json'
], function (echarts) {
var option;
option = {
xAxis: {
type: 'value'
},
yAxis: {
type: 'category',
data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
},
series: [
{
type: 'bar',
stack: 'total',
barMinHeight: 15,
data: [0, 0, 0, 0, 0, 0, 0]
},
{
type: 'bar',
stack: 'total',
barMinHeight: 15,
data: [0, 0, 0, 0, 0, 0, 0]
}
]
};
var chart = testHelper.create(echarts, 'main0', {
title: [
'Stacked bar series with minHeight (horizontal)'
],
option: option
// height: 300,
// buttons: [{text: 'btn-txt', onclick: function () {}}],
// recordCanvas: true,
});
});
</script>
<script>
require([
'echarts',
// 'map/js/china',
// './data/nutrients.json'
], function (echarts) {
var option;
option = {
yAxis: {
type: 'value'
},
xAxis: {
type: 'category',
data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
},
series: [
{
type: 'bar',
stack: 'total',
barMinHeight: 15,
data: [0, 0, 0, 0, 0, 0, 0]
},
{
type: 'bar',
stack: 'total',
barMinHeight: 15,
data: [0, 0, 0, 0, 0, 0, 0]
}
]
};
var chart = testHelper.create(echarts, 'main1', {
title: [
'Stacked bar series with minHeight (vertical)'
],
option: option
// height: 300,
// buttons: [{text: 'btn-txt', onclick: function () {}}],
// recordCanvas: true,
});
});
</script>
</body>
</html>| @@ -533,14 +538,18 @@ export function createProgressiveLayout(seriesType: string): StageHandler { | |||
| const startCoord = cartesian.dataToPoint([startValue, baseValue]); | |||
| baseCoord = startCoord[0]; | |||
| } | |||
| x = baseCoord; | |||
| x = lastStackCoords[baseValue] || baseCoord; | |||
There was a problem hiding this comment.
lastStackCoords[baseValue] could be 0 (e.g., grid.left is 0) so using || is not correct. Use retrieve2 instead.
|
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
|
Since @jttry didn't respond for some time. I'm going to close this PR and fix it by myself. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug probably brought in #16338.