Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): language code for Ukrainian is UK, not UA #17800

Merged

Conversation

striezel
Copy link
Contributor

Closes #17795.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Language code for Ukrainian language is UK, not UA, so the i18n file is renamed accordingly.

Fixed issues

See #17795.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

@echarts-bot
Copy link

echarts-bot bot commented Oct 20, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@plainheart plainheart merged commit 053f84c into apache:master Oct 21, 2022
@echarts-bot
Copy link

echarts-bot bot commented Oct 21, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart added this to the 5.4.1 milestone Oct 21, 2022
@striezel striezel deleted the i18n-ukrainian-language-code branch October 21, 2022 13:37
@plainheart plainheart removed this from the 5.4.1 milestone Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ukrainian locale name is incorrect
2 participants