Skip to content

feat(tooltip): add appendTo option to allow customizing tooltip container #18436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 2, 2023
Merged

feat(tooltip): add appendTo option to allow customizing tooltip container #18436

merged 19 commits into from
Sep 2, 2023

Conversation

viking7982
Copy link
Contributor

@viking7982 viking7982 commented Mar 28, 2023 •
edited by Ovilia
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

允许用户指定tooltip的容器

Fixed issues

Details

Before: What was the problem?

Tooltip只能插入到在当前DOM节点或者document.body中

After: How does it behave after the fixing?

用户可以指定tooltip的父节点

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 28, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@plainheart plainheart added the discussion-required Further discussion is required before we decide if this issue should be fixed. label Mar 28, 2023
plainheart
plainheart reviewed Mar 28, 2023
View reviewed changes
@viking7982 viking7982 requested review from plainheart and Ovilia March 31, 2023 10:49
@plainheart plainheart added this to the 5.5.0 milestone Apr 2, 2023
plainheart
plainheart requested changes Apr 3, 2023
View reviewed changes
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've left some comments. BTW, it would be better to add some test cases for this feature.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 3, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 3, 2023
plainheart
plainheart reviewed Apr 3, 2023
View reviewed changes
@viking7982
Copy link
Contributor Author

@plainheart Got it. Thanks~

@plainheart plainheart mentioned this pull request Aug 6, 2023
Closed
plainheart
plainheart reviewed Aug 7, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023 •
edited
Loading

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18436@2864cd1

@plainheart plainheart changed the title feat(tooltip): add appendTo option to allow customized tooltip container feat(tooltip): add appendTo option to allow customizing tooltip container Sep 2, 2023
@plainheart plainheart merged commit 428e2ad into apache:master Sep 2, 2023
@echarts-bot
Copy link

echarts-bot bot commented Sep 2, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart removed the discussion-required Further discussion is required before we decide if this issue should be fixed. label Sep 2, 2023
Ovilia
Ovilia reviewed Feb 1, 2024
View reviewed changes
Ovilia added a commit to apache/echarts-doc that referenced this pull request Feb 2, 2024
@Ovilia
doc: add doc for apache/echarts#18436
3d7d72d
@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Feb 2, 2024
@X-oss-byte X-oss-byte mentioned this pull request May 25, 2024
Open
@chandraguptsharma1 chandraguptsharma1 mentioned this pull request Jul 17, 2024
Open
@Elenore23 Elenore23 mentioned this pull request Jul 20, 2024
Open
@junior junior mentioned this pull request Jul 26, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Aug 7, 2024
Open
@bmotmans bmotmans mentioned this pull request Jan 21, 2025
Closed
@plainheart plainheart mentioned this pull request Mar 11, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia left review comments

@100pah 100pah 100pah left review comments

@plainheart plainheart plainheart approved these changes

Assignees
No one assigned
Labels
PR: doc ready PR: first-time contributor size/M
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

[Feature] 指定Tooltip的父节点
4 participants
@viking7982 @plainheart @Ovilia @100pah