Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axis): fix last tick doesn't show for single data #18469

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Apr 3, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Show last tick for single data

Fixed issues

#18453

Details

Before: What was the problem?

No last tick when data length is 1.

After: How does it behave after the fixing?

Has last tick when data length is 1.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

  • The first test case in axis-extrema.html

I've run visual tests for all cases and saw no problems.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 3, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart linked an issue May 18, 2023 that may be closed by this pull request
@Ovilia Ovilia merged commit a555684 into master May 23, 2023
@echarts-bot
Copy link

echarts-bot bot commented May 23, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-18453 branch May 23, 2023 08:00
@Ovilia Ovilia added this to the 5.5.0 milestone May 23, 2023
@plainheart plainheart modified the milestones: 5.5.0, 5.4.3 Jun 25, 2023
@plainheart plainheart changed the title fix(axis): show last tick for single data #18453 fix(axis): show last tick for single data Jun 25, 2023
@plainheart plainheart changed the title fix(axis): show last tick for single data fix(axis): fix last tick doesn't show for single data Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 图表只有一组数据时,缺少一侧刻度
3 participants