Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria): fix hard-coded series type name translation #19239

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Oct 24, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Support series type name in aria for custom series. And I found aria is missing for some i18n files so I added them.

Fixed issues

#18054

Details

Before: What was the problem?

Custom series type name is '自定义系列', which is not expected for languages other than Chinese.

After: How does it behave after the fixing?

Names in locale files are used.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 24, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@github-actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19239@625ec1f

@plainheart plainheart linked an issue Oct 25, 2023 that may be closed by this pull request
@plainheart plainheart added this to the 5.5.0 milestone Oct 25, 2023
@plainheart plainheart merged commit 6061e1d into master Oct 25, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Oct 25, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Aria label for series-custom is displayed in wrong language
2 participants