Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed using the toolbox to change line or bar charts but without using default boundaryGap configuration. #19428

Closed
wants to merge 0 commits into from

Conversation

zhaxnb
Copy link
Contributor

@zhaxnb zhaxnb commented Dec 21, 2023

…ng default boundaryGap configuration.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed using the toolbox to change line or bar charts but without using default boundaryGap configuration.

Fixed issues

Details

Before: What was the problem?

using the toolbox to change line or bar charts but without using default boundaryGap configuration.

After: How does it behave after the fixing?

start
image
before
image
after
image

change
image
image

official website demo
image
image

official demo
modify xAxis->boundaryGap: fasle to boundaryGap: true, click run then click switch to line chart.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Dec 21, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@zhaxnb zhaxnb changed the title Fixed using the toolbox to change line or bar charts without using default boundaryGap configuration. Fixed using the toolbox to change line or bar charts but without using default boundaryGap configuration. Dec 21, 2023
@Ovilia Ovilia requested a review from pissang December 22, 2023 02:35
@Ovilia
Copy link
Contributor

Ovilia commented Dec 22, 2023

@pissang Could you share the original design consideration and have a review of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants