Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.json exports #19543

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix package.json exports #19543

merged 1 commit into from
Jan 25, 2024

Conversation

100pah
Copy link
Member

@100pah 100pah commented Jan 24, 2024

Fix:

  1. Fix that some old version bundler (like rollup) do not recognize wildcard that not at the end of the patter string (e.g. "exports: {"./*.js": "xxx"}").
  2. Add readme to package.json.

See details in #19513 and ecomfe/zrender#1051

…nize wildcard that not at the end of the patter string (e.g. "exports: {"./*.js": "xxx"}"). (2) Add readme to package.json.
Copy link

echarts-bot bot commented Jan 24, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19543@d403486

@Ovilia Ovilia merged commit 61af513 into release Jan 25, 2024
2 checks passed
Copy link

echarts-bot bot commented Jan 25, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the module_default_esm_fix branch January 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants