fix(aria): avoid throwing error in SSR mode #19892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Skip setting aria label attribute when in SSR mode.
Fixed issues
#19191:
Details
Before: What was the problem?
aria-label
was set on the DOM element, but in SSR there is no DOM element, so it would throw when enablingaria
orlocals
in options when using SSR, because thedom
variable in code isnull
.Also, this makes the last example in this release note (Two color locals) not working in SSR.
After: How does it behave after the fixing?
No aria label was added, but locals are working in SSR.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information