Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axis): fix ticks overflowing grid area with dataZoom #20194

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jul 24, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

When using dataZoom, the ticks may overflow grid area in some cases.

Fixed issues

#20185

Details

Before: What was the problem?

Ticks may go outside of the grid.

image

After: How does it behave after the fixing?

Ticks don't go outside the grid.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jul 24, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.5.2 milestone Jul 24, 2024
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20194@5fb9e9d

@plainheart plainheart changed the title fix(axis): ticks overflowing grid area with dataZoom #20185 fix(axis): fix ticks overflowing grid area with dataZoom Jul 24, 2024
@plainheart plainheart merged commit eeaf52e into master Jul 24, 2024
2 checks passed
Copy link

echarts-bot bot commented Jul 24, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/customValues branch July 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When using axisTick customValues and dataZoom the grid extends beyond the chart
2 participants