Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axisLine.show option implemented for Gauge #9195

Merged
merged 2 commits into from Oct 11, 2018
Merged

Conversation

YuriGor
Copy link
Contributor

@YuriGor YuriGor commented Oct 10, 2018

As described in #9194 - echarts ignores axisLine.show option. Support for this option added by this commit.

As described in  apache#9194 - echarts ignores axisLine.show option. Support for this option added by this commit.
src/chart/gauge/GaugeView.js Outdated Show resolved Hide resolved
src/chart/gauge/GaugeView.js Outdated Show resolved Hide resolved
@Ovilia
Copy link
Contributor

Ovilia commented Oct 11, 2018

@YuriGor Thanks for your contribution.
Please fix the problems mentioned above before we can merge it.

@YuriGor
Copy link
Contributor Author

YuriGor commented Oct 11, 2018

Fixed

@Ovilia Ovilia merged commit c11beb0 into apache:master Oct 11, 2018
@Ovilia
Copy link
Contributor

Ovilia commented Oct 11, 2018

@YuriGor Thanks for your contribution! 🌟🌟🌟🌟🌟
Now you are one of the ECharts contributors. Since we joined Apache group, you need to assign ICLA for your first PR.
Please fill in the PDF and print it, then sign on it and send the scanned file to dev@echarts.apache.org and oviliazhang@gmail.com.
This may be a little tricky, and sorry for the trouble. This is required for the first time your commit is merged in. If you refused, your commit will be backed off.

And are you interested in being an ECharts committer? This has more restrict rules than contributors. Committers are those who contribute more frequently and play more important roles on ECharts project.

After being a committer:

  • You can have write access to the ECharts code
  • You can mange issues (add tags, assign to someone, ...)
  • You can discuss about features with us committers more frequently with Email
  • You name and personal page link will be displayed at ECharts Website About page
  • See this for more information

If you are interested, here's what you can do:

  • Subscribe our mailing list by send an email to dev-subscribe@echarts.apache.org
  • When you want to discuss with us about something, send email to dev@echarts.apache.org
  • Help others by replying issues regularly
  • Make more useful pull requests (fix bugs or make enhancement in issues)

Here are some issues that may be easier to be fixed: https://github.com/apache/incubator-echarts/projects/3

And you will be invited to be a committer when we think your contribution and knowledge of ECharts project is enough. We are looking forward to this! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants