[ISSUE #2979] replaced 'get + null check + creating empty list'

apache · Apr 17, 2023 · 7a5746e · 7a5746e
1 parent effa041
commit 7a5746e
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/...apache/eventmesh/runtime/core/protocol/http/processor/LocalUnSubscribeEventProcessor.java b/...apache/eventmesh/runtime/core/protocol/http/processor/LocalUnSubscribeEventProcessor.java
@@ -155,12 +155,7 @@ public void handler(final HandlerService.HandlerSpecific handlerSpecific, final
                         if (!StringUtils.equals(unSubscribeUrl, client.getUrl())) {
                             clientUrls.add(client.getUrl());
 
-                            List<String> urls = idcUrls.get(client.getIdc());
-                            if (urls == null) {
-                                urls = new ArrayList<>();
-                                idcUrls.put(client.getIdc(), urls);
-
-                            }
+                            List<String> urls = idcUrls.computeIfAbsent(client.getIdc(), list -> new ArrayList<>());
                             urls.add(StringUtils.deleteWhitespace(client.getUrl()));
                         }
 
@@ -271,12 +266,7 @@ private void registerClient(final HttpEventWrapper requestWrapper,
             final String groupTopicKey = client.getConsumerGroup() + "@" + client.getTopic();
 
             List<Client> localClients =
-                eventMeshHTTPServer.getSubscriptionManager().getLocalClientInfoMapping().get(groupTopicKey);
-
-            if (localClients == null) {
-                localClients = new ArrayList<>();
-                eventMeshHTTPServer.getSubscriptionManager().getLocalClientInfoMapping().put(groupTopicKey, localClients);
-            }
+                eventMeshHTTPServer.getSubscriptionManager().getLocalClientInfoMapping().computeIfAbsent(groupTopicKey, list -> new ArrayList<>());
 
             boolean isContains = false;
             for (final Client localClient : localClients) {